Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SonarCloud Trigger #5995

Closed
wants to merge 5 commits into from
Closed

Add SonarCloud Trigger #5995

wants to merge 5 commits into from

Conversation

koppor
Copy link
Member

@koppor koppor commented Feb 22, 2020

SonarCloud offers great code quality analysis. This PR enables it.

Refs #5991

@JabRef JabRef deleted a comment from sonarcloud bot Feb 22, 2020
@JabRef JabRef deleted a comment from sonarcloud bot Feb 22, 2020
@tobiasdiez
Copy link
Member

I still have to see valuable recommendations from these static code analyzers, but well let's try another one ;-)

Why is this PR needed? It appears that sonarcloud is already posting to PRs (which is a bit annoying to be honest, would have preferred a github action)

@Siedlerchr
Copy link
Member

I'm also against using them. They have more false positives than valuable recommendations. Annoying

@koppor
Copy link
Member Author

koppor commented Feb 22, 2020

I agree that the comments are annoying. We are trying to turn them off.

Nevertheless having all tools running enables JabRef being part of teaching Software Engineering. For instance, statement such as "more false positives than valuable recommendations" can be quantified when a) the analysis results are available and b) results of other products are available. Otherwise, that statement makes an impression to me made out of the blue based on other experiences, but not with the current code at hand.

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@koppor
Copy link
Member Author

koppor commented Feb 22, 2020

Because of https://community.sonarsource.com/t/disable-github-merge-request-comments/18520/19, I will not go forward. (PR commenting cannot be disabled)

Ticket https://jira.sonarsource.com/browse/SCCOMM-19 - please vote for it 🎉

@koppor koppor closed this Feb 22, 2020
@koppor koppor deleted the enable-sonarcloud branch February 22, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants